Ssl socket activation #2323
Open
Ssl socket activation #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't exactly understand why the error occurred. Is there anything I need to fix? Can you explain? |
steelman
force-pushed
the
ssl-socket-activation
branch
from
12b3997
to
9cafdbb
Compare
steelman
force-pushed
the
ssl-socket-activation
branch
from
9cafdbb
to
0a67f4b
Compare
|
Ping? |
steelman
force-pushed
the
ssl-socket-activation
branch
from
0a67f4b
to
8d1df30
Compare
When adding a socket from an fd search the list of configured sockets for a socket with the same name. If such socket is found and it has SSL context configured with https-socket, move the context to the received socket because the configured one won't be bound anyway.
steelman
force-pushed
the
ssl-socket-activation
branch
from
8d1df30
to
11dae8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I am not mistaken, it isn't possible at the moment to configure uWSGI to receive sockets from systemd and use them as SSL sockets. These patches (actually the last one) makes uWSGI grab SSL context from
uwsgi_socketconfigured in a config file and apply it to a socket received from systemd (while detaching it from the original structure).For an SSL configuration to be applied to a socket received from systemd its computed name must match the name configured with
https-socket.WARNING! Although I have tested it for both IPv4 and IPv6 and it works for me, I am not entirely sure this is the right way to do it. Please, review the patches carefully.